Skip to content

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Jan 6, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style
  • Refactor
  • Doc
  • Other, please describe:

The description of the PR:

  • For Add test modules and corresponding unit tests #475 .
  • Add test modules and corresponding unit tests.
  • The core code is put into the core module.
  • I plan to add two separate test modules for javax ee and jakarta ee namespaces, I first initialized part of tests for javax ee namespace.
  • The base Github Actions CI includes a package task for the core and a test task for the test module.
  • For other database tests, I hope to complete it through testcontainers in other PRs. First complete the testing of h2database 2.x.
  • Since setup-java no longer contains the initial jdk7 image, use jdk8 as the core build test image.
  • test-ci I recommend testing only jdk17 and jdk19, as this will simplify what we need to test, especially to exclude the use of lombok.

Other information:

@linghengqian linghengqian marked this pull request as ready for review January 6, 2023 11:19
@linghengqian
Copy link
Contributor Author

  • Not sure why CodeQL keeps failing. My local normal.

@linghengqian
Copy link
Contributor Author

@huayanYu Let me know your review.

@huayanYu huayanYu merged commit 5a4207d into baomidou:master Jan 9, 2023
@linghengqian linghengqian deleted the test branch January 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants