-
Notifications
You must be signed in to change notification settings - Fork 14
Fix optional dependencies in AutoReport
#131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 78.50% 79.10% +0.60%
==========================================
Files 5 5
Lines 521 536 +15
==========================================
+ Hits 409 424 +15
Misses 112 112 🚀 New features to boost your workflow:
|
get_distribution_dependenciesAutoReport
|
|
1f24cbd to
87a1bcf
Compare
|
@user27182, if this is good to go, let's merge this in lieu of #130 and get a release out. |
Maybe also consider reviewing #135 and #137 before a release? A use case I want to support in the |
Will do! |
AutoReportcurrently erroneously includes optional deps as required deps, e.g. frommain:This PR fixes this by adding a
separate_extrasoption toget_distribution_dependenciesto properly distiguish core from optional deps.Note: This PR was originally considered to be a feature (new
separate_extrasoption), but I thinkAutoReportclassifying optional deps as core can be considered a bug, so overall it may be OK to label this as a bugfix and possibly patched as v0.10.3