Add helper function to preserve XML declaration as processing instruction #44358
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiranSachintha
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #44358 +/- ##
============================================
- Coverage 75.09% 75.08% -0.01%
- Complexity 58585 58590 +5
============================================
Files 3599 3599
Lines 226340 226383 +43
Branches 29441 29453 +12
============================================
+ Hits 169975 169988 +13
- Misses 46923 46947 +24
- Partials 9442 9448 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| BXml item = XmlUtils.parse("<root>" + value + "</root>"); | ||
| return item.children(); | ||
| String xml = value.trim(); | ||
| if (xml.startsWith(XML_DECLARATION)) { |
There was a problem hiding this comment.
Couldn't an XML file also start with processing instructions like <?php or <?mso-application instead?
| if (version != null) { | ||
| piData.append("version=\"").append(version).append("\""); | ||
| } | ||
|
|
There was a problem hiding this comment.
Shall we remove these new lines after each if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #https://github.com/wso2-enterprise/wso2-integration-internal/issues/2231
Approach
Samples
Remarks
Check List