Skip to content

Refactor CompileTask and CreateDependencyGraphTask to add balToolToml check #44345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

Refactor CompileTask and CreateDependencyGraphTask to add balToolToml check #44345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cli/ballerina-cli/src/main/java/io/ballerina/cli/task/CompileTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ public CompileTask(PrintStream out,
}
@Override
public void execute(Project project) {
if (ProjectUtils.isProjectEmpty(project) && skipCompilationForBalPack(project)) {
if (ProjectUtils.isProjectEmpty(project) && skipCompilationForBalPack(project) &&
project.currentPackage().balToolToml().isEmpty()) {
throw createLauncherException("package is empty. Please add at least one .bal file.");
}
if (project.workspaceProject().isPresent()) {
Expand All @@ -110,7 +111,7 @@ public void execute(Project project) {
project.currentPackage().packageVersion();
}
// Print the source
this.out.println("\t" + sourceName);
this.out.println(" " + sourceName);
if (skipTask) {
return;
}
Expand Down Expand Up @@ -230,7 +231,8 @@ public void execute(Project project) {

Optional<Diagnostic> projectLoadingDiagnostic = ProjectUtils.getProjectLoadingDiagnostic().stream().filter(
diagnostic -> diagnostic.diagnosticInfo().code().equals(
ProjectDiagnosticErrorCode.DEPRECATED_RESOURCES_STRUCTURE.diagnosticId())).findAny();
ProjectDiagnosticErrorCode.DEPRECATED_RESOURCES_STRUCTURE.diagnosticId())).
findAny();

projectLoadingDiagnostic.ifPresent(out::println);
PackageCompilation packageCompilation = project.currentPackage().getCompilation();
Expand Down
2 changes: 1 addition & 1 deletion cli/ballerina-cli/src/main/java/io/ballerina/cli/task/CreateDependencyGraphTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public CreateDependencyGraphTask(PrintStream err, PrintStream out) {

@Override
public void execute(Project project) {
if (ProjectUtils.isProjectEmpty(project)) {
if (ProjectUtils.isProjectEmpty(project) && project.currentPackage().balToolToml().isEmpty()) {
throw createLauncherException("package is empty. Please add at least one .bal file.");
}
System.setProperty(CentralClientConstants.ENABLE_OUTPUT_STREAM, "true");
Expand Down