Replace lodash dependency with lodash.isequal. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the lodash dependency brings in the entire lodash library, which is an issue for some serverless environments like Cloudflare Pages/Workers which require a quick start up time. This commit replaces the lodash library with the isEqual function that is being used.
|
According to https://lodash.com/per-method-packages, the Lodash per-method packages are "discouraged and they will be removed in v5." The following results in small code bundles provided that you are using tree shaking: import isEqual from "lodash/isEqual"; |
lpsinger
added a commit
to lpsinger/remix-seo
that referenced
this pull request
Sep 18, 2023
|
See #12. |
lpsinger
added a commit
to nasa-gcn/remix-seo
that referenced
this pull request
Sep 18, 2023
balavishnuvj
approved these changes
Jan 30, 2024
lpsinger
added a commit
to lpsinger/remix-seo
that referenced
this pull request
Jan 30, 2024
This reverts commit fe0bc53.
lpsinger
added a commit
to lpsinger/remix-seo
that referenced
this pull request
Jan 30, 2024
|
Note that this PR does not represent the current best practice for using lodash with bundlers. I suggest #12 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the lodash dependency brings in the entire lodash library, which is an issue for some serverless environments like Cloudflare Pages/Workers which require a quick start up time. This commit replaces the lodash library with the isEqual function that is being used.