announcements - New Frontend System NavItem Icon Switch #4838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Wanlin <[email protected]>
Changed Packages
|
gaelgoth
approved these changes
Aug 3, 2025
|
Make sense 👍, thank you @awanlin for the change |
lijumathews
pushed a commit
to lijumathews/community-plugins
that referenced
this pull request
Aug 4, 2025
Signed-off-by: Andre Wanlin <[email protected]> Signed-off-by: cxz821 <[email protected]>
lijumathews
pushed a commit
to lijumathews/community-plugins
that referenced
this pull request
Aug 4, 2025
Signed-off-by: Andre Wanlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
The Backstage Notifications uses the
NotificationsIconas seen here in code and here in the Demo Site.The Announcements plugin uses the same icon in its NavItem for the New Frontend System. I propose we switch this for
RecordVoiceOverIcon. We use this already for the Announcements search results. Here is what this looks like:✔️ Checklist
Signed-off-byline in the message. (more info)