Type error in Scaffolder backend module servicenow/v1.41.1 #4812
Conversation
Signed-off-by: Diana Janickova <[email protected]>
Signed-off-by: Diana Janickova <[email protected]>
Signed-off-by: Diana Janickova <[email protected]>
Signed-off-by: Diana Janickova <[email protected]>
|
Tested the plugin locally - the template for creating an incident works correctly. Screen.Recording.2025-07-30.at.16.12.16.movWhen I updated the template to contain an empty string for the tableName, the validation failed, which is the expected behaviour. 
|
djanickova
requested review from
AndrienkoAleksandr,
dzemanov,
PatAKnight and
a team
as code owners
There was a problem hiding this comment.
Thanks for this @djanickova, this all looks right to me from my review. We do need a changeset so these changes get released, more details on that here: https://github.com/backstage/community-plugins/blob/main/CONTRIBUTING.md#creating-changesets
| sysparmSuppressAutoSysField: z | ||
| .boolean() | ||
| .optional() | ||
| .describe( | ||
| 'True to suppress auto generation of system fields (default: false)', | ||
| ), | ||
| sysparmView: z | ||
| .string() | ||
| .optional() | ||
| .describe( | ||
| 'Render the response according to the specified UI view (overridden by sysparm_fields)', | ||
| ), | ||
| sysparmQueryNoDomain: z | ||
| .boolean() | ||
| .optional() | ||
| .describe( | ||
| 'True to access data across domains if authorized (default: false)', | ||
| ), |
There was a problem hiding this comment.
Why have you removed these params?
| sysparmSuppressAutoSysField: z | ||
| .boolean() | ||
| .optional() | ||
| .describe( | ||
| 'True to suppress auto generation of system fields (default: false)', | ||
| ), | ||
| sysparmView: z | ||
| .string() | ||
| .optional() | ||
| .describe( | ||
| 'Render the response according to the specified UI view (overridden by sysparm_fields)', | ||
| ), | ||
| sysparmQueryNoDomain: z | ||
| .boolean() | ||
| .optional() | ||
| .describe( | ||
| 'True to access data across domains if authorized (default: false)', | ||
| ), |
There was a problem hiding this comment.
Same with these, can we add them back?
|
@awanlin this is a pull request to version bump PR that already contains changeset, so no need to add it here. |
Signed-off-by: Diana Janickova <[email protected]>
Hey, I just made a Pull Request!
Updated the relevant functions to use the provided zod param for validation. This also required some changes to types and minor fixes in tests which were using nonexistent keys.
✔️ Checklist
Signed-off-byline in the message. (more info)