Skip to content

feat: Add PDB #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

feat: Add PDB #248

merged 1 commit into from
Apr 10, 2025

Conversation

Prims47
Copy link
Contributor

@Prims47 Prims47 commented Feb 5, 2025

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@Prims47 Prims47 requested a review from a team as a code owner February 5, 2025 17:45
@ChrisJBurns
Copy link
Contributor

@Prims47 Got a couple failures in pipeline

@Prims47
Copy link
Contributor Author

Prims47 commented Feb 6, 2025

@Prims47 Got a couple failures in pipeline

@ChrisJBurns Indeed => The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.

I launch ct lint + helm template and eveything is ok on my side

@ChrisJBurns
Copy link
Contributor

@Prims47 You should be able to rebase with main now and have the Python error fixed due to the merging of #249

@Prims47
Copy link
Contributor Author

Prims47 commented Feb 11, 2025

@Prims47 You should be able to rebase with main now and have the Python error fixed due to the merging of #249

@ChrisJBurns It's up to date 😄

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit/suggestion. Otherwise it looks good 🙂

Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

tumido
tumido previously requested changes Feb 26, 2025
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for a late response. I had to focus on different projects... 🙈

Copy link

github-actions bot commented Mar 6, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 6, 2025
@github-actions github-actions bot closed this Mar 12, 2025
@ChrisJBurns ChrisJBurns reopened this Mar 12, 2025
@github-actions github-actions bot removed the stale label Mar 13, 2025
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@ChrisJBurns
Copy link
Contributor

@Prims47 Am just cleaning up some schema failures in the build and I'll get right back to you on this PR. You may need to rebase with main, but as far as your changes are concerned, I think they're all good.

Copy link

github-actions bot commented Apr 6, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@Prims47
Copy link
Contributor Author

Prims47 commented Apr 10, 2025

@Prims47 Am just cleaning up some schema failures in the build and I'll get right back to you on this PR. You may need to rebase with main, but as far as your changes are concerned, I think they're all good.

Hello,

Sorry for the delay,

I rebase main ! :)

@ChrisJBurns
Copy link
Contributor

@Prims47 I shall approve just to ensure things are all good and passing. But before we merge, you'll have to bump the minor version of the Chart instead if thats ok?

@ChrisJBurns
Copy link
Contributor

@Prims47 Pipeline passed so it looks good. If you bump the minor version instead to 2.5.0 then we should be good to merge and get it released! 🚀

Signed-off-by: Ilan Zerath <[email protected]>
@Prims47
Copy link
Contributor Author

Prims47 commented Apr 10, 2025

@Prims47 Pipeline passed so it looks good. If you bump the minor version instead to 2.5.0 then we should be good to merge and get it released! 🚀

it's updated

@ChrisJBurns ChrisJBurns dismissed tumido’s stale review April 10, 2025 16:17

All comments by Tom have been addressed

@ChrisJBurns ChrisJBurns merged commit 63ec4eb into backstage:main Apr 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants