-
Notifications
You must be signed in to change notification settings - Fork 91
feat: Add PDB #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PDB #248
Conversation
@Prims47 Got a couple failures in pipeline |
@ChrisJBurns Indeed => I launch |
a25df58
to
10a972d
Compare
@ChrisJBurns It's up to date 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit/suggestion. Otherwise it looks good 🙂
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again for a late response. I had to focus on different projects... 🙈
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
@Prims47 Am just cleaning up some schema failures in the build and I'll get right back to you on this PR. You may need to rebase with |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hello, Sorry for the delay, I rebase main ! :) |
@Prims47 I shall approve just to ensure things are all good and passing. But before we merge, you'll have to bump the minor version of the Chart instead if thats ok? |
@Prims47 Pipeline passed so it looks good. If you bump the minor version instead to |
Signed-off-by: Ilan Zerath <[email protected]>
it's updated |
All comments by Tom have been addressed
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.