Add spec.revisionHistoryLimit config possibility for Deployment resource #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Hoyer <[email protected]>
mhoyer
force-pushed
the
add-revision-history-limit
branch
from
6ea6328 to
e62a93b
Compare
Signed-off-by: Marcel Hoyer <[email protected]>
mhoyer
force-pushed
the
add-revision-history-limit
branch
from
e62a93b to
0d2363e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
It simply adds the possibility to configure the revisionHistoryLimit property of the Deployment resource template, but keeps the default to 10.
Existing or Associated Issue(s)
none
Additional Information
Especially when using GitOps approach to deploy applications to a kubernetes cluster it makes not real sense to keep revisions of the deployments as those are actually kind of persisted inside the underlying SCM, which drives the deployment and its history.
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.