Skip to content

fix: fix resolve error #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2020
Merged

fix: fix resolve error #77

merged 4 commits into from
Nov 24, 2020

Conversation

iahu
Copy link
Contributor

@iahu iahu commented Nov 19, 2020 •
edited
Loading

  • resolve index file of all extensions
  • add jsx and tsx scopes
  • support typescript scope
  • fix syntax error in resolve_as_directory

@iahu iahu changed the title fix: fix resolve index error fix: fix resolve error Nov 21, 2020
@iahu
Copy link
Contributor Author

iahu commented Nov 21, 2020

hi @aziz could you please take a look on my PR, thank you.

@niksy
Copy link
Contributor

niksy commented Nov 24, 2020 •
edited
Loading

@aziz can we get this merged?

Pinging @cristianl since there was recent activity from him!

niksy
niksy reviewed Nov 24, 2020
View reviewed changes
hyper_click/generic_path_resolver.py Outdated
@@ -150,7 +150,7 @@ def resolve_as_file(self, path_name):
if path.isfile(path_name):
return path_name

with_ext = self.resolve_with_exts(path_name)
with_ext = self.resolve_with_exts(path_name) or self.resolve_with_exts(path.join(path_name, 'index'))
Copy link
Contributor

@niksy niksy Nov 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iahu is this necessary? There is already index file check in resolve_index method. Maybe that method should be changed to self.resolve_with_exts(path.join(path_name, 'index')) and this line left unmodified?

@cristianl cristianl merged commit 93a87e1 into aziz:master Nov 24, 2020
@cristianl
Copy link
Collaborator

cristianl commented Nov 24, 2020 •
edited
Loading

Released as 2.3. Thank you @iahu!

@niksy
Copy link
Contributor

niksy commented Nov 26, 2020

@cristianl it’s not available on Package Control?

@jfcherng
Copy link
Contributor

jfcherng commented Nov 26, 2020 •
edited
Loading

Probably should be tagged as 2.3.0 since 2.3 is not a valid semantic version.

https://packagecontrol.io/docs/submitting_a_package#Step_4

  1. Pick a Versioning Strategy

If you are using GitHub or BitBucket for your hosting, you will need to create a tag each time you want to make a new version available to users. The tag names must be a semantic version number.

@cristianl cristianl mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@niksy niksy niksy left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iahu @niksy @cristianl @jfcherng