fix(utils): Changed to be able to refer to default settings proposed …

[misumisumi]

Changed to be able to refer to default settings from extend_config and load_plugin functions proposed in #972

[charliie-dev]

from: #972 (comment)

If i want to add new settings based on default setting, i can just pass in a table, i.e.

settings["lsp_deps"] = {
	"bashls",
	"clangd",
	"html",
	"jsonls",
	"lua_ls",
	"pylsp",
	"zls", -- zig lsp
}

If i want to replace/remove some default settings, i need to pass in a function, i.e.

settings["lsp_deps"] = function()
    return {
		"lua_ls",
		"pylsp",
		"zls", -- zig lsp
    }
end

Did I missing understanding anything?

[misumisumi]

The override method is fine
Here's a PR for a proposed change that allows users to reference the default settings table when creating functions.

[charliie-dev]

aha, got it.

So for referring default settings and adding new settings:

local default_setting = require("core.settings")
settings["lsp_deps"] = function(default_settings.lsp_deps)
    return {
		"zls", -- zig lsp
    }
end

For rewriting default settings:

settings["lsp_deps"] = function()
    return {
		"lua_ls",
		"pylsp",
		"zls", -- zig lsp
    }
end

am i right?

[misumisumi]

The suggestion is to leave room for users to do their own merges.
The default setting is:

settings["lsp_deps"] = {
	"bashls",
	"clangd",
	"html",
	"jsonls",
	"lua_ls",
	"pylsp",
}

We can change the settings as follows. (use extend_config())

• Merge setting

settings["lsp_deps"] = {
  "zls", -- zig lsp
}
-- Return:
-- {
-- "bashls",
-- "clangd",
-- "html",
-- "jsonls",
-- "lua_ls",
-- "pylsp",
--  "zls"
-- }

• Override

settings["lsp_deps"] = function(default)
  return {
    default[5] -- "lua_ls"
    default[6] -- "pylsp"
    "zls", -- zig lsp
  }
end
-- default:
-- {
-- "bashls",
-- "clangd",
-- "html",
-- "jsonls",
-- "lua_ls",
-- "pylsp",
-- }

-- Return:
-- {
-- "lua_ls",
-- "pylsp",
-- "zls"
-- }

load_plugin() will have default as the whole configuration.
That is, as follows.

-- Override bufferline
return function(default)
  return {
		options = {
			number = nil,
 			...
			color_icons = default.options.color_icons, -- reference default opt
    }
  }
end
-- default:
-- options = {
--   number = nil,
--   modified_icon = icons.ui.Modified,
--   buffer_close_icon = icons.ui.Close,
--   ...
--}

[charliie-dev]

tks for the explanations!

[charliie-dev]

lgtm