-
-
Notifications
You must be signed in to change notification settings - Fork 239
Support return type'ResourceData' #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doesn't everything in the |
BTW: /extensions/scripting/lua-bindings/auto should be disabled on GitHub pull process. I have always uncheck it 😔 |
Is there any specific reason you prefer to not have them in the repository? It would mean users would need to generate the bindings themselves, and that's just an extra setup step that may cause problems, especially for newer users of the engine. |
I mean the automatic generated stuff, the automatic binding stuff |
I understand, but I mean what is the reason for not wanting the generated files to be stored in the repository? The reason I ask is that the only time the auto-generated files are affected is if the engine code changes, and that is only relevant for engine developers, and not the majority of users of the engine. Forcing typical users of the engine to generate the bindings seems like an unnecessary step. |
@rh101 I think what he meant is any pull request that tries to modify lua-auto files should be denied, not actually removing the auto generated lua files from the repo |
Of course! |
Sorry, I completely misunderstood what you meant in your initial post, but now I get what you mean, and I agree with you. @DelinWorks I think I need to avoid posting so late at night 🤦♂️ |
Can you even do that in github? |
THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch
dev
, otherwise will be rejected immediately.Describe your changes
Issue ticket number and link
Checklist before requesting a review