Skip to content

Conversation

tkzcfc
Copy link
Contributor

@tkzcfc tkzcfc commented Jul 21, 2022

THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch dev, otherwise will be rejected immediately.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@rh101
Copy link
Contributor

rh101 commented Jul 21, 2022

Doesn't everything in the /extensions/scripting/lua-bindings/auto folder get overwritten with the automatic binding creation script? If that is the case, then this PR is not valid, and any entries need to be done somewhere else, perhaps in the "manual" folder.

@aismann
Copy link
Contributor

aismann commented Jul 21, 2022

BTW: /extensions/scripting/lua-bindings/auto should be disabled on GitHub pull process. I have always uncheck it 😔

@rh101
Copy link
Contributor

rh101 commented Jul 21, 2022

BTW: /extensions/scripting/lua-bindings/auto should be disabled on GitHub pull process. I have always uncheck it 😔

Is there any specific reason you prefer to not have them in the repository?

It would mean users would need to generate the bindings themselves, and that's just an extra setup step that may cause problems, especially for newer users of the engine.

@aismann
Copy link
Contributor

aismann commented Jul 21, 2022

I mean the automatic generated stuff, the automatic binding stuff

@rh101
Copy link
Contributor

rh101 commented Jul 21, 2022

I mean the automatic generated stuff, the automatic binding stuff

I understand, but I mean what is the reason for not wanting the generated files to be stored in the repository? The reason I ask is that the only time the auto-generated files are affected is if the engine code changes, and that is only relevant for engine developers, and not the majority of users of the engine. Forcing typical users of the engine to generate the bindings seems like an unnecessary step.

@DelinWorks
Copy link
Contributor

DelinWorks commented Jul 21, 2022

@rh101 I think what he meant is any pull request that tries to modify lua-auto files should be denied, not actually removing the auto generated lua files from the repo

@aismann
Copy link
Contributor

aismann commented Jul 21, 2022

Of course!
On your repository you can do what ever you want.
I mean it for axis only.
PR to "automatic created stuff (executables, apk's, etc) should be permit.
So PRs like this is not possible.

@rh101
Copy link
Contributor

rh101 commented Jul 22, 2022

PR to "automatic created stuff (executables, apk's, etc) should be permit.
So PRs like this is not possible.

Sorry, I completely misunderstood what you meant in your initial post, but now I get what you mean, and I agree with you.

@DelinWorks I think I need to avoid posting so late at night 🤦‍♂️

@DelinWorks
Copy link
Contributor

PR to "automatic created stuff (executables, apk's, etc) should be permit.
So PRs like this is not possible.

Sorry, I completely misunderstood what you meant in your initial post, but now I get what you mean, and I agree with you.

@DelinWorks I think I need to avoid posting so late at night 🤦‍♂️

Can you even do that in github?

@halx99 halx99 merged commit 9791189 into axmolengine:dev Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants