Fix for crashes in several tests #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix update override warning Improve code
This reverts commit 1744a48.
…p for event dispatcher." This reverts commit 88094f0.
Re-add missing zip files for Unzip test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Re-added zip files that were removed a long while back. These files are required by the Unzip tests. This commit diff shows when they were removed:
1ae9cd3#diff-30c89ee12d5dd3d94bb0df104924229627a3862032b88b0324e021370655b422
Fix incorrect random number index being generated, where the random number being generated ended up going over the allowed index range. The valid indexes of the frames in the animation are 01 to 14, yet the code was incorrectly generating 14 then adding 1 to it, which ended up as 15 (that frame does not exist).
Issue ticket number and link
Checklist before requesting a review