Factor in protected nodes when creating global Z node priority map for event dispatcher #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix update override warning Improve code
This reverts commit 1744a48.
…p for event dispatcher." This reverts commit 88094f0.
Closed
…p for event dispatcher." This reverts commit 8accc0a.
…istener. Add getProtectedChildren()
…ll correctly receive touch input even if parent node is not propagating touches.
halx99
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Just prior to dispatching an event, the event dispatcher creates a sorted list of nodes based on their Z position. This was never factoring in nodes of type ProtectedNode, so it meant that touch events would not be sent to such nodes ahead of their parent node. If the parent node happens to block propagation of events, then the protected child nodes would never receive any touch events, which is not correct.
More info here.
Note that the Tab Control UI test has been adapted to show that this functionality now works. Without the changes to ProtectedNode and EventDispatcher, the tab controls in the test cannot be activated, since no touch event is sent to them.
Issue ticket number and link
#1221
Checklist before requesting a review