-
Notifications
You must be signed in to change notification settings - Fork 29
feat(cosmwasm): coordinator v2 migration check #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 comments
kulikthebird
requested changes
Oct 6, 2025
kulikthebird
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks! 👍
…ordinator-migration-check
This reverts commit 85fdda3.
kulikthebird
reviewed
Oct 9, 2025
Base automatically changed from
fix/coordinator-migration-default-provers
to
main
October 10, 2025 18:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a script that checks whether or not the coordinator v2's migration succeeded with respect to the multisig contract. In particular, it checks that every prover/chain pair in the coordinator can be found in the multisig contract. For more details, please see the Synchronizing Prover-to-Chain Map section of ARC-8.
testing
This script has been tested on devnet-amplifier.
Note
Introduces a read-only migration check that validates coordinator vs multisig prover/chain mappings, adds a
check
CLI command, refactors logging/types, and updates release docs.constructCoordinatorChainProverPairs
,constructMultisigChainProverPairs
,coordinatorStoresMultisigAddress
, andcheckCoordinatorToVersion2_1
to compare coordinator and multisig prover mappings and multisig address.queryChainsFromRouter
now usesCosmWasmClient
; internal contract fields use snake_case (chain_name
,prover_address
, etc.).console.log/error
withprintInfo
/printError
and improve messages.checkMigration
entrypoint for version-matched checks.check
command inmigrate.ts
(viaaddAmplifierQueryContractOptions
,mainQueryProcessor
) to run coordinator migration verification with optional--coordinator
/--multisig
.MigrationCheckOptions
andProtocolContracts
to support verification.printInfo
/printError
.releases/cosmwasm/2025-09-Coordinator-v2.1.1.md
with a new post-migration check step and command usage.Written by Cursor Bugbot for commit 299d2ae. This will update automatically on new commits. Configure here.
Greptile Overview
Updated On: 2025-10-02 18:48:49 UTC
Summary
This PR introduces a post-migration verification system for coordinator v2.1.0 migrations in the CosmWasm ecosystem. The implementation adds functionality to check that coordinator migrations succeeded correctly by validating consistency between the coordinator and multisig contracts.The changes span four files:
types.ts
to support migration checking withMigrationCheckOptions
andProtocolContracts
interfacescoordinator.ts
with functions to query and compare prover/chain pairs between coordinator and multisig contractsmigrate.ts
through a newcheck
command that provides a user-friendly interface for running migration verificationThe verification system works by querying both the coordinator and multisig contracts to retrieve their respective prover/chain mappings, then ensuring every prover/chain pair in the coordinator can be found in the multisig contract. This addresses requirements from ARC-8 to ensure protocol state consistency after coordinator migrations. The implementation uses read-only
CosmWasmClient
operations and follows existing patterns in the codebase for contract interaction and CLI structure.Important Files Changed
Changed Files
MigrationCheckOptions
andProtocolContracts
interfacesConfidence score: 4/5
Sequence Diagram