Skip to content

Conversation

k4m4
Copy link
Collaborator

@k4m4 k4m4 commented Oct 1, 2025

As of XRPLGateway v1.3.2, token instance registration doesn't need to be performed manually: commonprefix/axelar-amplifier#29.

Hence, we remove the outdated register-token-instance script and update the XRPL token deployment guides.


Note

Removes manual token instance registration by deleting the script and updating XRPL deployment/linking docs to drop that step and renumber.

  • Code:
    • Delete deprecated xrpl/register-token-instance.js.
  • Docs:
    • xrpl/README.md: Remove Register Token Instance section.
    • xrpl/docs/deploy-local-token.md: Remove step for token instance registration; update instruction to repeat steps 4-7.
    • xrpl/docs/deploy-remote-token.md: Remove XRPL Token Instance Registration section.
    • xrpl/docs/link-token.md: Drop token instance registration step; renumber subsequent steps (remote token registration and mint role grant).

Written by Cursor Bugbot for commit f2769a6. This will update automatically on new commits. Configure here.

Greptile Overview

Updated On: 2025-10-01 14:46:55 UTC

Summary

This PR removes outdated manual token instance registration functionality from XRPL token deployment workflows. The changes are driven by XRPLGateway v1.3.2, which now automatically handles token instance registration that previously required manual intervention via a dedicated script.

The PR eliminates the register-token-instance.js script entirely and updates all related documentation across three deployment guides: link-token, deploy-remote-token, and deploy-local-token. The documentation updates involve removing step-by-step instructions for manual token instance registration and renumbering subsequent steps to maintain proper flow.

This change simplifies the token deployment process by removing a manual step that was error-prone and is now handled automatically by the gateway contract. The updates ensure that users won't attempt to perform deprecated manual registration processes when the system handles this automatically.

Important Files Changed

Changed Files
Filename Score Overview
xrpl/register-token-instance.js 5/5 Complete removal of deprecated manual token instance registration script
xrpl/README.md 5/5 Removed the 'Register Token Instance' section from main XRPL documentation
xrpl/docs/link-token.md 5/5 Eliminated step 6 (token instance registration) and renumbered subsequent steps
xrpl/docs/deploy-remote-token.md 5/5 Removed Section 3 'XRPL Token Instance Registration' from remote token guide
xrpl/docs/deploy-local-token.md 5/5 Removed step 8 token registration and updated instructions to repeat steps 4-7 instead of 4-8

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it removes deprecated functionality and updates documentation
  • Score reflects straightforward cleanup of outdated tooling with no breaking changes to active functionality
  • No files require special attention as all changes are consistent documentation and script removal

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Docs as Documentation Files
    participant Guide as Token Deployment Guides

    Dev->>Docs: "Remove outdated register-token-instance script"
    Dev->>Docs: "Delete xrpl/register-token-instance.js"
    
    Dev->>Guide: "Update XRPL token deployment guides"
    Note over Guide: Remove references to manual token instance registration
    
    Dev->>Guide: "Update deploy-local-token.md"
    Note over Guide: Remove steps requiring register-token-instance script
    
    Dev->>Guide: "Update deploy-remote-token.md" 
    Note over Guide: Simplify deployment process without manual registration
    
    Dev->>Guide: "Update link-token.md"
    Note over Guide: Remove token instance registration requirements
    
    Note over Dev,Guide: XRPLGateway v1.3.2 handles token instance registration automatically
Loading

@k4m4 k4m4 marked this pull request as ready for review October 1, 2025 14:45
@k4m4 k4m4 requested a review from a team as a code owner October 1, 2025 14:45
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@isi8787 isi8787 merged commit c91c247 into axelarnetwork:main Oct 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants