Skip to content

Conversation

kulikthebird
Copy link
Contributor

@kulikthebird kulikthebird commented Sep 30, 2025

why?

The API of the new Coordinator v2 contract and the current implementation of deployment scripts are not aligned. The legacy methods that contructs instantiate messages for VotingVerifier, Gateway and MultisigProver does not follow the same schema that is required by the new Coordinator contract.

how?

This PR introduce a new methods and defines schemas to properly construct the InstantiateChainContract message.

testing

Manual testing on a custom devnet set up based on the latest axelar-amplifier


Note

Implements Coordinator v2 message construction via a new CoordinatorManager, refactors config to expose axelar/chains with chainId, and updates processors/CLI to use the new API.

  • Coordinator v2 integration:
    • Add cosmwasm/coordinator.ts with CoordinatorManager to build instantiate_chain_contracts messages (Gateway/Verifier/Prover), including domain separator handling and strict validation.
    • submit-proposal.js: rework instantiate-chain-contracts to use CoordinatorManager, require admin/salt, fetch/validate code IDs, and persist deployment info.
  • Config refactor:
    • Introduce AxelarConfig (adds chainId) and make ConfigManager expose axelar/chains directly, implementing FullConfig.
    • Add helpers: getChainConfig, getContractConfig, getContractConfigByChain; adjust initContractConfig, saveConfig, and fee access; enhance validation to include axelar.chainId.
  • Processor updates:
    • cosmwasm/processor.ts: switch processor signatures to use ConfigManager, and connect via configManager.axelar.rpc/gasPrice.
  • Utilities cleanup:
    • Remove legacy getInstantiateChainContractsMessage and generateDeploymentName; export new initContractConfig.

Written by Cursor Bugbot for commit fa6ecf7. This will update automatically on new commits. Configure here.

@kulikthebird kulikthebird changed the title Fix/coordinator v2 api fix(cosmwasm,coordinator): coordinator v2 api Sep 30, 2025
@kulikthebird kulikthebird marked this pull request as ready for review September 30, 2025 16:52
@kulikthebird kulikthebird requested a review from a team as a code owner September 30, 2025 16:52
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@kulikthebird kulikthebird self-assigned this Sep 30, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@isi8787 isi8787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging please check branch with axelarate

@kulikthebird kulikthebird merged commit dc3ee31 into main Oct 3, 2025
11 checks passed
@kulikthebird kulikthebird deleted the fix/coordinator_v2_api branch October 3, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants