-
Notifications
You must be signed in to change notification settings - Fork 29
fix(cosmwasm,coordinator): coordinator v2 api #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
861938b
to
89ee5d3
Compare
89ee5d3
to
2423ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
isi8787
reviewed
Sep 30, 2025
isi8787
reviewed
Sep 30, 2025
isi8787
reviewed
Sep 30, 2025
AttissNgo
reviewed
Sep 30, 2025
AttissNgo
approved these changes
Oct 2, 2025
isi8787
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging please check branch with axelarate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
The API of the new Coordinator v2 contract and the current implementation of deployment scripts are not aligned. The legacy methods that contructs instantiate messages for
VotingVerifier
,Gateway
andMultisigProver
does not follow the same schema that is required by the new Coordinator contract.how?
This PR introduce a new methods and defines schemas to properly construct the
InstantiateChainContract
message.testing
Manual testing on a custom devnet set up based on the latest
axelar-amplifier
Note
Implements Coordinator v2 message construction via a new CoordinatorManager, refactors config to expose axelar/chains with chainId, and updates processors/CLI to use the new API.
cosmwasm/coordinator.ts
withCoordinatorManager
to buildinstantiate_chain_contracts
messages (Gateway/Verifier/Prover), including domain separator handling and strict validation.submit-proposal.js
: reworkinstantiate-chain-contracts
to useCoordinatorManager
, requireadmin
/salt
, fetch/validate code IDs, and persist deployment info.AxelarConfig
(addschainId
) and makeConfigManager
exposeaxelar
/chains
directly, implementingFullConfig
.getChainConfig
,getContractConfig
,getContractConfigByChain
; adjustinitContractConfig
,saveConfig
, and fee access; enhance validation to includeaxelar.chainId
.cosmwasm/processor.ts
: switch processor signatures to useConfigManager
, and connect viaconfigManager.axelar.rpc/gasPrice
.getInstantiateChainContractsMessage
andgenerateDeploymentName
; export newinitContractConfig
.Written by Cursor Bugbot for commit fa6ecf7. This will update automatically on new commits. Configure here.