Skip to content

Conversation

nbayindirli
Copy link
Contributor

@nbayindirli nbayindirli commented Sep 30, 2025

Note

Updates solana-5 AxelarGateway address, switches event parsing to gas-service CPI, removes ITS CLI, bumps/introduces event-CPI/anchor dependencies, and adjusts upgrade docs to solana program deploy.

  • Solana CLI / ITS:
    • Remove ITS CLI module: delete solana/src/its.rs and drop Its subcommands from solana/src/main.rs (instruction/query/build paths).
  • Gateway:
    • Event parsing: gateway_event_stack::build_program_event_stack now uses parse_gas_service_log instead of parse_gateway_logs in solana/src/gateway.rs.
    • Dependencies: add event-cpi, event-cpi-macros, anchor-discriminators(-macros) to axelar-solana-gateway; adjust related crates.
  • Gas Service:
    • Dependencies: add anchor-discriminators-macros to axelar-solana-gas-service.
  • Config:
    • axelar-chains-config/info/devnet-amplifier.json: update solana-5 AxelarGateway.address and upgradeAuthority.
  • Docs:
    • releases/solana/2025-09-GMP-upgrade-vanilla.md: change upgrade command to solana program deploy --program-id $PROGRAM_PDA $PROGRAM_PATH.
  • Dependencies (Cargo.lock):
    • Introduce anchor-discriminators, event-cpi; remove/adjust some deps (e.g., event-utils), and bump several crate versions (e.g., mpl-token-metadata, num_cpus, openssl-src, socket2).

Written by Cursor Bugbot for commit 67ba637. This will update automatically on new commits. Configure here.

Greptile Overview

Updated On: 2025-09-30 06:50:53 UTC

Summary

This PR implements a test deployment of a new Gateway contract variant called 'gateway-event-cpi' to the solana-5 devnet environment. The changes span three key areas:
  1. Configuration Update: Updates the AxelarGateway contract address in the devnet-amplifier configuration from the old address to a newly deployed contract at gtwLmC1UUvmkVCN4NoXobHbLpQN2AZEZrWyqc7Q13QA. This configuration change maintains all other parameters like domain separator, connection type, and authority addresses while only updating the contract reference.

  2. ITS Module Cleanup: Removes redundant parameters from multiple instruction function calls in the Solana ITS module. These changes affect functions for deploying interchain tokens, transferring operatorship, managing flow limiters, and handling minting operations. The removed parameters (like sender, proposer, accepter, adder, remover) were likely being passed to instruction functions that now derive these values automatically.

  3. Event Parsing Modification: Switches the event parsing function from parse_gateway_logs to parse_gas_service_log in the gateway events query functionality. This change specifically targets gas service event parsing rather than general gateway event parsing, likely to accommodate the new contract's event emission patterns.

The changes appear to be part of testing a new Gateway contract implementation that focuses on Cross-Program Invocation (CPI) functionality with gas service event handling capabilities. The PR title explicitly states this is for testing purposes and should not be merged.

Important Files Changed

Changed Files
Filename Score Overview
axelar-chains-config/info/devnet-amplifier.json 3/5 Updates AxelarGateway contract address for solana-5 chain to new deployment
solana/src/its.rs 4/5 Removes redundant parameters from multiple ITS instruction function calls
solana/src/gateway.rs 3/5 Switches event parsing from gateway logs to gas service logs

Confidence score: 3/5

  • This PR appears to be a test deployment with moderate risk due to configuration inconsistencies
  • Score reflects potential issues with incomplete configuration updates and functional changes to event parsing
  • Pay close attention to the configuration file for potential inconsistencies with SolanaVotingVerifier references

Sequence Diagram

sequenceDiagram
    participant User
    participant "Deployment Script" as Script
    participant "Solana Gateway" as Gateway
    participant "Axelar Network" as Axelar
    participant "Chain Config" as Config

    User->>Script: "Initialize Gateway deployment"
    Script->>Config: "Read devnet-amplifier.json"
    Config-->>Script: "Return chain configuration"
    
    Script->>Script: "Parse initialization parameters"
    Note over Script: "Set operator, domain separator,<br/>verifier set, rotation delay"
    
    Script->>Gateway: "initialize_config()"
    Note over Gateway: "Deploy with gateway-event-cpi<br/>for enhanced event tracking"
    Gateway-->>Script: "Deployment transaction"
    
    Script->>Config: "Update chains config with new deployment"
    Note over Config: "Add solana-5 gateway contract<br/>address and configuration"
    Config-->>Script: "Configuration updated"
    
    Script->>Axelar: "Register gateway with amplifier connection"
    Axelar-->>Script: "Gateway registered"
    
    Script-->>User: "Gateway deployment complete"
    Note over User: "solana-5 gateway ready<br/>with event CPI functionality"
Loading

@nbayindirli nbayindirli requested a review from a team as a code owner September 30, 2025 06:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"contracts": {
"AxelarGateway": {
"address": "gtwRtcJ6CT8a7bsymztPEDzaMM5d3h6PN6vXeHtkESq",
"address": "gtwLmC1UUvmkVCN4NoXobHbLpQN2AZEZrWyqc7Q13QA",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The gateway address change may require updating the corresponding SolanaVotingVerifier sourceGatewayAddress at line 1950 to maintain consistency between gateway and verifier configurations.

Suggested change
"address": "gtwLmC1UUvmkVCN4NoXobHbLpQN2AZEZrWyqc7Q13QA",
"sourceGatewayAddress": "gtwLmC1UUvmkVCN4NoXobHbLpQN2AZEZrWyqc7Q13QA",
Prompt To Fix With AI
This is a comment left during a code review.
Path: axelar-chains-config/info/devnet-amplifier.json
Line: 1409:1409

Comment:
logic: The gateway address change may require updating the corresponding SolanaVotingVerifier sourceGatewayAddress at line 1950 to maintain consistency between gateway and verifier configurations.

```suggestion
          "sourceGatewayAddress": "gtwLmC1UUvmkVCN4NoXobHbLpQN2AZEZrWyqc7Q13QA",
```

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is correct, we are going to need to deploy a new voting verifier

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@isi8787 isi8787 closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants