Skip to content

Conversation

rista404
Copy link
Contributor

@rista404 rista404 commented Sep 25, 2025

why?

This PR adds a release document for upgrading Hedera's ITS contract, specifically the Token Manager implementation.

how?

The fix is c6fda1781dfb0a00d9e74e420cca7beba9bbcda8. The release doc instructs to pull this commit, rebuild ITS and reinstall it before upgrading.

I haven't included any devnet-amplifier configuration as it was removed in #1018

Feel free to suggest any changes, I wasn't sure how to version the fork and subsequently kept 2.1.0 in the salt, with the addition of patch-1.

testing

Follow the EVM checklist and the additional registration test. Let me know if you can't find a native token with lower max-supply. I haven't included any token addresses as you can only register a single token once.

Here's a transaction that registers a canonical token with lower max supply.

Greptile Overview

Updated On: 2025-09-25 19:31:37 UTC

Summary

This PR adds release notes for a Hedera ITS max-supply patch that fixes token registration issues for tokens with finite supply. The patch includes a specific commit that lowers approval amounts to the max supply of tokens with finite supply, preventing registration problems.

  • Adds comprehensive deployment instructions and testing checklist for the patch
  • Documents the fix for token registration issues with non-max supply tokens
  • Includes specific testing instructions for validating the patch functionality
  • Missing required --proxySalt parameters in deployment commands which are needed for consistent derived contract addresses

Confidence Score: 3/5

  • This PR is relatively safe but has deployment parameter issues that need to be addressed
  • Score reflects missing critical deployment parameters that could cause address derivation issues, though the overall documentation structure is sound
  • The release document needs proxySalt parameters added to deployment commands

Important Files Changed

File Analysis

Filename        Score        Overview
releases/hedera/2025-09-Hedera-ITS-v.2.1.0-patch-1.md 4/5 Well-structured release documentation for Hedera ITS patch with minor salt naming inconsistency

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant ITS as Hedera ITS Contract
    participant TM as TokenManager
    participant Token as HTS Token
    
    Note over Dev,Token: Hedera ITS Max-Supply Patch Deployment
    
    Dev->>Dev: Checkout specific commit c6fda178
    Dev->>Dev: Run npx hardhat compile
    Dev->>Dev: Create .env config
    
    Dev->>ITS: Deploy new implementation with salt
    Note right of ITS: ts-node evm/deploy-its.js -s "v2.1.0 patch-1" --reuseProxy
    
    Dev->>ITS: Upgrade to new implementation
    Note right of ITS: ts-node evm/deploy-its.js --upgrade
    
    Dev->>ITS: Run post-deployment checks
    Note right of ITS: Verify contract functionality
    
    Note over Dev,Token: Testing the Max-Supply Fix
    
    Dev->>Token: Find token with finite max supply
    Note right of Token: Using HashScan to locate token
    
    Dev->>ITS: Register canonical token
    ITS->>TM: Set approval amount to token's max supply
    Note right of TM: Fixed: Previously failed for non-max supply tokens
    
    TM-->>ITS: Registration successful
    ITS-->>Dev: Token registration complete
Loading

Note

Adds Hedera ITS v2.1.1 release notes (TokenManager approval capped to finite max supply) with deployment/checklist, and updates a Solana guide command to use ts-node.

  • Releases:
    • Hedera ITS v2.1.1 (releases/hedera/2025-09-Hedera-ITS-v2.1.1.md):
      • Notes patch to TokenManager lowering approval to token max supply for finite-supply tokens.
      • Adds deployment steps (env setup, evm/deploy-its.js create2/upgrade), network addresses, and post-deploy checks.
      • Provides EVM checklist (fund/approve/mint/deploy/transfer) and a targeted registration test.
    • Solana ITS docs (releases/solana/2025-07-ITS-v1.0.0.md):
      • Fixes interchain transfer command to ts-node evm/its.js ....

Written by Cursor Bugbot for commit 2d7e8e2. This will update automatically on new commits. Configure here.

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 19:28
@rista404 rista404 requested a review from a team as a code owner September 25, 2025 19:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a release document for a patch upgrade to Hedera's ITS (Interchain Token Service) contract that fixes an issue with token registration for tokens with finite max supply.

  • Adds release documentation for ITS v2.1.0-patch-1 targeting a Token Manager implementation fix
  • Includes deployment instructions and testing procedures specific to the max-supply patch
  • Provides comprehensive checklist for verifying the upgrade across different networks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

- small word changes - remove devnet-amplifier from the release doc
…xelar-contract-deployments into hedera-its-max-supply-fix
@blockchainguyy blockchainguyy merged commit 065f4f8 into axelarnetwork:main Oct 7, 2025
10 checks passed
kulikthebird pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants