-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(common,evm): cli-utils.ts #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nbayindirli
wants to merge
14
commits into
main
Choose a base branch
from
refactor/cli-utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
isi8787
reviewed
Sep 25, 2025
AttissNgo
reviewed
Sep 25, 2025
AttissNgo
approved these changes
Sep 25, 2025
AttissNgo
reviewed
Sep 25, 2025
kulikthebird
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the next TS refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
evm
how?
evm/cli-utils
(andcommon/cli-utils
dependency)Greptile Summary
Updated On: 2025-09-09 04:17:55 UTC
This PR refactors the CLI utilities from JavaScript to TypeScript as part of a broader repository migration strategy, starting with the EVM module. The changes convert two critical CLI utility files (
common/cli-utils.js
andevm/cli-utils.js
) to TypeScript equivalents with proper type annotations and modern ES6 module syntax.The refactoring introduces a new
BaseOptions
interface incommon/cli-utils.ts
that provides structured typing for configuration options shared across multiple modules. The EVM-specific utilities extend this with anEvmOptions
interface that includes optional properties likeartifactPath
,contractName
,deployMethod
,salt
,skipExisting
,upgrade
, andpredictOnly
. All existing functionality is preserved while adding compile-time type checking and better IDE support.Key architectural changes include converting CommonJS
require()
statements to ES6 imports, replacingmodule.exports
with named exports, and adding comprehensive TypeScript type annotations to function parameters and return values. The migration maintains the same API surface while modernizing the codebase foundation for future TypeScript adoption across other modules like CosmWasm, Stellar, and Sui.Important Files Changed
Changed Files
Confidence score: 3/5
Sequence Diagram