Skip to content

Conversation

snigdhasjg
Copy link

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

If secret is not a JSON string, it will take it as string.
Name of spring property will be secret name last suffix.
eg. if secret name is service1/secret1 the property name will be secret1.
Similar approach as 3.0.x

This also inherits behaviour like adding prefix to the property name.

💡 Motivation and Context

Fixes #636

💚 How did you test it?

Unit test only.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: secrets-manager Secrets Manager integration related issue label Jan 27, 2023
@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label Jan 27, 2023
@snigdhasjg snigdhasjg marked this pull request as ready for review January 27, 2023 11:33
@maciejwalkowiak maciejwalkowiak added this to the 2.4.3 milestone Jan 27, 2023
@maciejwalkowiak maciejwalkowiak merged commit f074d2f into awspring:2.4.x Jan 27, 2023
@maciejwalkowiak
Copy link
Contributor

Thanks @snigdhasjg !

@snigdhasjg snigdhasjg deleted the 2.4.x branch January 27, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: secrets-manager Secrets Manager integration related issue type: documentation Documentation or Samples related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants