Skip to content

Conversation

fhieber
Copy link
Contributor

@fhieber fhieber commented Nov 21, 2017

Pull Request Checklist

  • Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
    until you can check this box.
  • Unit tests pass (pytest)
  • System tests pass (pytest test/system)
  • Passed code style checking (./pre-commit.sh or manual run of pylint & mypy)
  • You have considered writing a test
  • Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
  • Updated CHANGELOG.md

Copy link
Contributor

@mjpost mjpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It might be nice to integrate into sacreBLEU, but I don't think that's necessary now.

@fhieber fhieber merged commit 21ce4c4 into master Nov 24, 2017
@fhieber fhieber deleted the chrf branch November 24, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants