Skip to content
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
e8e3821
Tweak build system
phdum-a Feb 27, 2025
ea3da3a
Add flag for MFEM to throw not abort
phdum-a Feb 27, 2025
f891030
Simplify printing using more fmt features
phdum-a Feb 27, 2025
2c009e0
Add small table class for csv printing
phdum-a Feb 27, 2025
d9f45ca
Add vdim to interpolation operator
phdum-a Feb 27, 2025
3e8a110
First pass at new postpro printers
phdum-a Feb 27, 2025
52df9cd
Clean up while loops
phdum-a Feb 27, 2025
f9e6bf1
Centralizes making output directory
phdum-a Feb 27, 2025
e260dbd
Change post_dir to fs::path
phdum-a Feb 27, 2025
eb611af
Rework PostOperator
phdum-a Feb 27, 2025
330dc07
Add missing include
phdum-a Feb 27, 2025
915aff4
Fix table tests with changed default
phdum-a Feb 27, 2025
5e638c3
Clang-tidy tweaks
phdum-a Feb 27, 2025
f2d3cc6
Bugfix in eigenmode port_Q printer
phdum-a Feb 27, 2025
922bcb2
Fix bug in s-parameters printer
phdum-a Feb 27, 2025
70ddfb1
Use variadic method to remove method
hughcars Feb 27, 2025
a68fbbe
Simplify PostOperator to remove mutability of cache and optional
hughcars Feb 27, 2025
0d2a557
Move simple accessors to header, gather measurements methods together…
hughcars Feb 27, 2025
2f94778
Trying to fix issue with cmake cache
hughcars Feb 27, 2025
550b1f6
Initial upgrade to remove state from printers, only driven should be …
hughcars Feb 27, 2025
0262c8f
Remove state from more printers.
hughcars Feb 27, 2025
819133b
fmt tweaks
phdum-a Feb 27, 2025
a270399
Centralize post_op output folder name
phdum-a Feb 27, 2025
fb77730
Revert "Initial upgrade to remove state from printers, only driven sh…
phdum-a Feb 28, 2025
163f8ee
Split out units converts out of IOData
phdum-a Mar 5, 2025
173e5a3
Split out Units class into separate header
phdum-a Mar 5, 2025
674be83
Recollect all measurments in PostOperator
phdum-a Mar 14, 2025
cfcc57d
Fix constexpr static assert to be c++17
phdum-a Mar 15, 2025
4897dd4
Adjust fmt spec for older versions
phdum-a Mar 16, 2025
40c20f0
Fmt fix
phdum-a Mar 16, 2025
196ec23
Adjust includes
phdum-a Mar 17, 2025
856668f
Small fixes; added comments; update changelog
phdum-a Mar 17, 2025
27a33d7
Fix spelling errors
phdum-a Mar 18, 2025
f9ef3f1
Split table into cpp
hughcars Mar 24, 2025
409968c
Fix copy construct error
hughcars Mar 24, 2025
621cd34
MeasurePrintAll -> MeasureAndPrintAll
hughcars Mar 24, 2025
7008f33
Remove **** section headings
hughcars Mar 24, 2025
e55ad41
Simplify type trait for fem_op_t, and apply style
hughcars Mar 24, 2025
e27f283
Typo fixes, one small bug in iodata
hughcars Mar 24, 2025
780313c
Remove debris
hughcars Mar 24, 2025
3a47a0e
Fix style
hughcars Mar 24, 2025
4070f08
Remove energy from mode output for eigenmode simulations
hughcars Mar 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Checks: >
-bugprone-easily-swappable-parameters,
-bugprone-reserved-identifier,
readability-*,
-readability-math-missing-parentheses,
-readability-convert-member-functions-to-static,
-readability-else-after-return,
-readability-function-cognitive-complexity,
Expand All @@ -29,6 +30,7 @@ Checks: >
-readability-named-parameter,
-readability-redundant-*,
-readability-string-compare,
-readability-uppercase-literal-suffix,
performance-*,
mpi-*,
openmp-*'
Expand Down
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,20 @@ The format of this changelog is based on
lumped port discovery to fail by reducing default from `1e-3` to `1e-12`.
- Fixed bug in Nastran mesh reader where carriage returns (`\r`) in the mesh file could
cause a failure to read the mesh.
- Changed post-processing, so that appropriate measurements are always written to disk as CSV
files. This is a breaking change, since users are now required to specify valid a output
folder in `config["Problem"]["Output"]`. Previously an empty string `""` would suppress file
printing. ParaView printing is still controlled and suppressed by the `"Save"` or `"SaveStep"`
options in the `config["Solver"][...]`.
- Changed measurement and printing during post-processing substantially. This change is not
user-facing, but will enable future multi-excitation support. All measurements are now
performed as part of the `PostOperator` class, which is templated on solver type. The public
interface of the `PostOperator` has been simplified: measurements can no longer be called
individually, but are grouped in a `MeasurePrintAll` function. The actual printing of
measurements has moved out of individual solvers and is orchestrated by the `PostOperatorCSV`
class. Other helper classes include a small `Table` class (for data storage and formatting)
and a light wrapper `TableWithCSVFile` (with file interaction).
- Changed unit conversion interface: this was moved out of `IOData` into a separate `Units` class.

## [0.13.0] - 2024-05-20

Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
# CMake 3.21 was released in Jul. 2021 (required for HIP support)
cmake_minimum_required(VERSION 3.21)

set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

# Prohibit in-source builds
if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
message(FATAL_ERROR "In-source builds are prohibited")
Expand Down
4 changes: 4 additions & 0 deletions cmake/ExternalMFEM.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ if(CMAKE_BUILD_TYPE MATCHES "Debug|debug|DEBUG")
endif()
endif()

# Replace mfem abort calls with exceptions for testing, default off
set(PALACE_MFEM_USE_EXCEPTIONS NO)

set(MFEM_OPTIONS ${PALACE_SUPERBUILD_DEFAULT_ARGS})
list(APPEND MFEM_OPTIONS
"-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}"
Expand All @@ -91,6 +94,7 @@ list(APPEND MFEM_OPTIONS
"-DMFEM_USE_METIS_5=YES"
"-DMFEM_USE_CEED=NO"
"-DMFEM_USE_SUNDIALS=${PALACE_WITH_SUNDIALS}"
"-DMFEM_USE_EXCEPTIONS=${PALACE_MFEM_USE_EXCEPTIONS}"
)
if(PALACE_WITH_STRUMPACK OR PALACE_WITH_MUMPS)
list(APPEND MFEM_OPTIONS
Expand Down
2 changes: 2 additions & 0 deletions palace/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
# CMake 3.21 was released in Jul. 2021 (required for HIP support)
cmake_minimum_required(VERSION 3.21)

set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

# Prohibit in-source builds
if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
message(FATAL_ERROR "In-source builds are prohibited")
Expand Down
Loading