Skip to content

Conversation

@mengqiy
Copy link
Contributor

@mengqiy mengqiy commented Dec 8, 2022

Change etcd image to what it used to be due to lack of sh in the base image.
Use absolute path for bootstrap script.

Even though #328 has [DO-NOT-MERGE] in the title, it was merged before it's ready to be merged.

The new etcd images appear to be built with distroless or similar base image that doesn't have sh, while our etcd bootstrap script relies on it.

We can't upgrade etcd to newer image tag until we figure out how are we going to deal with the etcd bootstrap script.

This PR also changes the bootstrap script to use the absolute path instead of the relative path.

Change etcd image to what it used to be due to lack of sh in the base
image.
Use absolute path for bootstrap script.
@mengqiy
Copy link
Contributor Author

mengqiy commented Dec 8, 2022

Crated #331 to track it.

Copy link
Contributor

@hakuna-matatah hakuna-matatah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengqiy mengqiy merged commit f08d668 into awslabs:main Dec 8, 2022
@mengqiy mengqiy deleted the fiximagetags branch December 8, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants