Skip to content

Conversation

@premdass
Copy link
Contributor

@premdass premdass commented Nov 4, 2022

Updating latest image tags of EKS-D

Towards aws/eks-distro#1174

Issue #, if available:
aws/eks-distro#1174

Description of changes:
Updating the EKS-D image tags to latest

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Updating latest image tags of EKS-d 

Towards aws/eks-distro#1174
Copy link
Contributor

@hakuna-matatah hakuna-matatah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@premdass
Copy link
Contributor Author

premdass commented Nov 15, 2022

can somebody merge this when time permits pls ?

@hakuna-matatah hakuna-matatah merged commit a7dd1ab into awslabs:main Nov 15, 2022
@premdass premdass deleted the patch-1 branch November 17, 2022 12:00
@mengqiy
Copy link
Contributor

mengqiy commented Dec 5, 2022

@premdass These tags are not publicly accessible, which is not expected, right?
This is problematic when using the operator built from HEAD.
I'd suggest 2 solutions going forward:

  • Make those tags publicly accessible .
  • Revert this change until those tag are ready.

@mengqiy
Copy link
Contributor

mengqiy commented Dec 5, 2022

KIT operator is broken on the HEAD of main. This should really be caught by our CI.

@mengqiy
Copy link
Contributor

mengqiy commented Dec 5, 2022

Looking at aws/eks-distro#1174 (comment), it appears we are not using the right image tags in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants