Skip to content

docs: Adding localization support for zh #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hitsub2
Copy link
Contributor

@hitsub2 hitsub2 commented Jun 11, 2025

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

add zh locale support for #634

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@hitsub2 hitsub2 changed the title docs: adding localization support for zh docs: Adding localization support for zh Jun 12, 2025
@hitsub2
Copy link
Contributor Author

hitsub2 commented Jun 12, 2025

need to re-build for successfully deployment:

npm run build

@nabuskey
Copy link
Collaborator

Thanks for this! I can't read Chinese so I can't comment on the contents of the guide itself. However, for the AI contents I suggest move that to the AI on EKS repository. https://github.com/awslabs/ai-on-eks

@hitsub2
Copy link
Contributor Author

hitsub2 commented Jun 25, 2025

However, for the AI contents I suggest move that to the AI on EKS repository. https://github.com/awslabs/ai-on-eks

I think I can make another pr to ai-on-eks, but the existing data-on-eks still has AI-on-EKS section that need translation, right?

@hitsub2
Copy link
Contributor Author

hitsub2 commented Jun 25, 2025

Thanks for this! I can't read Chinese so I can't comment on the contents of the guide itself.

The translation was done by Amazon Q CLI, and then made some modifications by human review.

Copy link
Contributor

github-actions bot commented Aug 3, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 3, 2025
@vara-bonthu vara-bonthu removed the stale label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants