feat: Make clients and configurations sendable #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
changed the title
jbelkins
approved these changes
Dec 16, 2025
| @@ -58,7 +58,7 @@ extension ExplicitBlobInput { | |||
| val contents = getClientFileContents("Sources/Example", "ExampleClient.swift", context.manifest) | |||
| contents.shouldSyntacticSanityCheck() | |||
| val expectedContents = """ | |||
| public class ExampleClient: AWSClientRuntime.AWSServiceClient { | |||
| public final class ExampleClient: AWSClientRuntime.AWSServiceClient, Sendable { | |||
Contributor
There was a problem hiding this comment.
Rather than explicitly mark every client, we should just add Sendable conformance to ClientRuntime.Client protocol
| @@ -82,7 +82,7 @@ public class ExampleClient: AWSClientRuntime.AWSServiceClient { | |||
|
|
|||
| extension ExampleClient { | |||
|
|
|||
| public class ExampleClientConfiguration: AWSClientRuntime.AWSDefaultClientConfiguration & AWSClientRuntime.AWSRegionClientConfiguration & ClientRuntime.DefaultClientConfiguration & ClientRuntime.DefaultHttpClientConfiguration { | |||
| public final class ExampleClientConfiguration: AWSClientRuntime.AWSDefaultClientConfiguration & AWSClientRuntime.AWSRegionClientConfiguration & ClientRuntime.DefaultClientConfiguration & ClientRuntime.DefaultHttpClientConfiguration, @unchecked Sendable { | |||
Contributor
There was a problem hiding this comment.
I think we already discussed this, but using @unchecked Sendable here isn't appropriate because the client config is not actually safe to use across Swift Concurrency isolation boundaries; a class with var properties is not Sendable, even if the type of the var is Sendable.
Contributor
Author
There was a problem hiding this comment.
Discussed offline -- we want to refactor the configuration class to be a struct with immutable properties to achieve Sendability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.