Skip to content

Fix integration tests segmentation fault error #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025
Merged

Fix integration tests segmentation fault error #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcefcdf
Remove Integration Test github secrets and add OIDC authentication
ig15 Apr 16, 2025
b7454f1
Fix typo
ig15 Apr 16, 2025
d1a6b18
Merge branch 'main' of https://github.com/awslabs/aws-iot-device-clie…
ig15 Apr 18, 2025
86f46d1
Fix Integration Tests
ig15 Apr 18, 2025
113c146
Remove log
ig15 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/docker-images/integration-tests/ubuntu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ RUN wget https://zlib.net/zlib-1.3.1.tar.gz -O /tmp/zlib-1.3.1.tar.gz && \
make install && \
cd /home/dependencies

RUN wget https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.gz -O /tmp/boost.tar.gz && \
RUN wget https://archives.boost.io/release/1.87.0/source/boost_1_87_0.tar.gz -O /tmp/boost.tar.gz && \
tar xzvf /tmp/boost.tar.gz && \
cd boost_1_81_0 && \
cd boost_1_87_0 && \
./bootstrap.sh && \
./b2 install link=static && \
cd /home/dependencies
Expand Down
20 changes: 13 additions & 7 deletions integration-tests/source/IntegrationTestResourceHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@ extern std::string THING_NAME;
static const char *TAG = "IntegrationTestResourceHandler.cpp";

IntegrationTestResourceHandler::IntegrationTestResourceHandler(const ClientConfiguration &clientConfig)
: iotClient(IoTClient(clientConfig)), ioTSecureTunnelingClient(IoTSecureTunnelingClient(clientConfig))
: iotClient(IoTClient(clientConfig)),
ioTSecureTunnelingClient(IoTSecureTunnelingClient(clientConfig)),
logger(std::unique_ptr<Aws::Utils::Logging::ConsoleLogSystem>(
new Aws::Utils::Logging::ConsoleLogSystem(Aws::Utils::Logging::LogLevel::Info)))
{
targetArn = GetTargetArn(THING_NAME);
logger = unique_ptr<Aws::Utils::Logging::ConsoleLogSystem>(
new Aws::Utils::Logging::ConsoleLogSystem(Aws::Utils::Logging::LogLevel::Info));
}

void IntegrationTestResourceHandler::CreateJob(const string &jobId, const string &jobDoc)
Expand All @@ -66,7 +67,6 @@ void IntegrationTestResourceHandler::CreateJob(const string &jobId, const string
request.SetJobId(jobId);
request.SetDocument(jobDoc);
request.AddTargets(targetArn);

CreateJobOutcome outcome = iotClient.CreateJob(request);

if (outcome.IsSuccess())
Expand Down Expand Up @@ -504,6 +504,12 @@ void IntegrationTestResourceHandler::Log(
{
ss << string{" "} << errorMessage;
}

logger->LogStream(logLevel, TAG, ss);
}
if (logger)
{
logger->LogStream(logLevel, TAG, ss);
}
else
{
std::cerr << "[ERROR] Logger not initialized. Message: " << ss.str() << std::endl;
}
}
Loading