Circular dependency issue

[ansidev]

This is the error in my boot log:

sudo journalctl -b -p 3
<date> <time> <host-name> systemd[1]: multi-user.target: Job nodeadm-run.service/start deleted to break ordering cycle starting with multi-user.target/start

After the investigation, I found that there is a circular dependency issue:

amazon-eks-ami/templates/al2023/runtime/rootfs/etc/systemd/system/nodeadm-run.service

Line 6 in 79a0460

After=nodeadm-config.service cloud-final.service

amazon-eks-ami/templates/al2023/runtime/rootfs/etc/systemd/system/nodeadm-run.service

Line 14 in eb6757e

WantedBy=multi-user.target

https://github.com/canonical/cloud-init/blob/c3848d5747f0d1342ea703b6838e1c568c776d9a/systemd/cloud-final.service#L5

After=multi-user.target

multi-user.target wants nodeadm-run.service but:

• nodeadm-run.service must run after cloud-final.service.
• cloud-final.service must run after multi-user.target.

[ansidev]

From testing, setting WantedBy=cloud-init.target in nodeadm-run.service is the only approach which works.

[cartermckinnon]

I think the systemd circuit breaker is doing the expected thing in this case, but fixing our unit seems reasonable to me. Feel free to open a PR @ansidev

[mselim00]

Can you share more details on how you ran into the initial error? AFAICT, cloud-final.service file included in AL2023 does not include the referenced dependency from upstream cloud-init.

After=multi-user.target

[ndbaker1]

Can you share more details on how you ran into the initial error? AFAICT, cloud-final.service file included in AL2023 does not include the referenced dependency from upstream cloud-init.

After=multi-user.target

+1, the build of cloud-init AL2023 comes with today is based on 22.2.2, which uses a template to decide whether or not to add the After=multi-user.target directive. @ansidev if you have some extra details about the environment you're running in that would be helpful to confirm.

but it seems like more folks have noticed this regression, and there's been some chatter on the original PR: canonical/cloud-init#5830 (comment). a generic solution that doesn't need to assume the existence of the cloud-init.target either would be nice. in theory we just need the last stable .target, even graphical.target would technically suffice 🤷.