Skip to content

Conversation

@fred-vogt
Copy link

@fred-vogt fred-vogt commented Jul 2, 2020

amazon-ecr-credential-helper$ (cd ecr-login; go mod vendor)

amazon-ecr-credential-helper$ (cd ecr-login; go get -u github.com/aws/[email protected])
amazon-ecr-credential-helper$ (cd ecr-login; go mod vendor)

amazon-ecr-credential-helper$ make
git rev-parse --short=7 HEAD > GITCOMMIT_SHA
. ./scripts/shared_env && ./scripts/build_binary.sh ./bin/local 0.4.0 2d84703
Built ecr-login

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fred-vogt
Copy link
Author

@samuelkarp - There is some changes here you may not want.

  1. go version in the go.mod file
  2. some ## explicit comments in the vendor/modules.txt file

@b-dean b-dean mentioned this pull request Oct 7, 2020
@kzys
Copy link
Contributor

kzys commented Nov 12, 2020

Thanks for the contribution. I'm sorry that we couldn't review this PR promptly.

I'm going to merge #240 to upgrade the SDK to 1.35.x. This will fix the IMDSv2 issue as well.

@kzys kzys closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants