api: enable shared config by default #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Feb 4, 2020
The AWS SDK for Go ignores the shared config file `~/.aws/config` by default, which is the inherited behavior of amazon-ecr-credential-helper. This commit changes the default behavior to have `~/.aws/config` enabled. The shared config file usage can be controlled through the environment variable `AWS_SDK_LOAD_CONFIG`. To disable this behavior, set `AWS_SDK_LOAD_CONFIG=false`.
andrewsharon
force-pushed
the
198-EnableSharedConfigFile
branch
from
e2403d6 to
2389db6
Compare
|
Thanks for the feedback! I've made the changes and updated the PR. |
|
This code looks good to me; just waiting for the Travis build to complete before approving. |
samuelkarp
approved these changes
Feb 7, 2020
This was referenced Jan 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Description of changes:
The AWS SDK for Go ignores the shared config file
~/.aws/configbydefault, which is the inherited behavior of
amazon-ecr-credential-helper. This commit changes the default behavior
to have
~/.aws/configenabled.The shared config file usage can be controlled through the environment
variable
AWS_SDK_LOAD_CONFIG. To disable this behavior, setAWS_SDK_LOAD_CONFIG=false.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.