Skip to content

Conversation

scjudd
Copy link
Contributor

@scjudd scjudd commented Sep 19, 2019

Issue #, if available: #184

Description of changes:

  • Made GITCOMMIT_SHA a dependency of the docker Make target.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scjudd scjudd force-pushed the fix-docker-build-submodule branch from 06c7f08 to 415bb87 Compare September 19, 2019 18:50
Copy link
Contributor

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (and sorry for the very delayed review!)

@samuelkarp samuelkarp merged commit 415bb87 into awslabs:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants