Skip to content

S3 Multipart upload/download update #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Aug 5, 2025
Merged

S3 Multipart upload/download update #3275

merged 53 commits into from
Aug 5, 2025

Conversation

jterapin
Copy link
Contributor

@jterapin jterapin commented Jul 24, 2025

Objectives:

  • Ensure that temp file is deleted when multipart download fails (and do not overrwrite if a file exists)
  • Added various validation checks

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

Copy link

Detected 1 possible performance regressions:

  • aws-sdk-s3.get_object_small_ms - z-score regression: 10.43 -> 15.13. Z-score: 20.03

@jterapin jterapin changed the title [WIP] S3 Multipart upload/download update S3 Multipart upload/download update Jul 28, 2025
@jterapin jterapin marked this pull request as ready for review July 28, 2025 21:03
Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine in general. Be sure to run integration tests and also do manual tests.

Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, be sure to run integ tests and some manual testing. Even better if you want to add a cucumber test.

@jterapin jterapin merged commit b0541aa into version-3 Aug 5, 2025
27 checks passed
@jterapin jterapin deleted the s3-utility-update branch August 5, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants