chore(scripts): turn off verdaccio benchmark script #7350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
internal JS-5878
Description
This replaces the actions of the test:size script (verdaccio-based benchmark) with the bundler benchmark.
Testing
yarn test:size
Additional context
The benchmark script is not quite working as originally intended, with the report markdown not being updated.
Furthermore, the test itself runs long and uses verdaccio, which still makes many calls out to NPM, which in turn has availability issues.
Repairing the benchmark runner is a big task at the moment, but it should be turned off for now to reduce the churn of internal build failures caused by it.
The loss in test coverage includes the lock for accidentally publishing a dependency on aws-crt, the original reason for its creation. However, we have not run into this test failure in the last few years, meaning it is low risk.
Checklist
*.integ.spec.ts
).@public
tag and enable doc generation on the package?