Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 16, 2025

Issue

internal JS-5878

Description

This replaces the actions of the test:size script (verdaccio-based benchmark) with the bundler benchmark.

Testing

yarn test:size

Additional context

The benchmark script is not quite working as originally intended, with the report markdown not being updated.
Furthermore, the test itself runs long and uses verdaccio, which still makes many calls out to NPM, which in turn has availability issues.

Repairing the benchmark runner is a big task at the moment, but it should be turned off for now to reduce the churn of internal build failures caused by it.

The loss in test coverage includes the lock for accidentally publishing a dependency on aws-crt, the original reason for its creation. However, we have not run into this test failure in the last few years, meaning it is low risk.

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner September 16, 2025 17:29
@kuhe kuhe merged commit e5b756a into main Sep 16, 2025
6 checks passed
@kuhe kuhe deleted the chore/verdaccio branch September 16, 2025 18:01
Copy link

github-actions bot commented Oct 1, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants