Do not sign X-Forwarded-For header if present on the request #6369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, AWS SDKs sign most custom headers, including the X-Forwarded-For header, during SigV4 authentication, causing signature validation failures in specific scenarios.
In some rare cases related to building application-layer proxies (in my case, specifically for CloudWatch RUM), attempting to add a
X-Forwarded-For
header by any normal method results in a InvalidSignatureException. This is becauseX-Forwarded-For
is a hop-by-hop header that many reverse proxies modify (presumably including the reverse proxies used by CloudWatch RUM).This change proposes to stop signing the
X-Forwarded-For
header with SigV4(a). This is basically the same as #5895 but with a different header.Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License