feat: add durable_wait_for_callback decorator #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new decorator that enables cleaner API for wait_for_callback
operations by allowing submitter functions to accept additional
parameters that are bound at call time.
The decorator wraps callables that take callback_id, context, and
additional parameters, returning a function that binds those extra
parameters and produces a submitter compatible with wait_for_callback.
Changes:
* Add durable_wait_for_callback decorator to context module
* Export decorator from package __init__ for public API
* Add integration test validating parameter binding and name propagation
* Verify operation names are correctly set on STEP and CALLBACK operations
Example usage:
@durable_wait_for_callback
def submit_task(callback_id, context, task_name, priority):
external_api.submit(task_name, priority, callback_id)
result = context.wait_for_callback(submit_task(my_task, priority=5))
bchampp
approved these changes
Dec 2, 2025
Member
bchampp
left a comment
bchampp
left a comment
There was a problem hiding this comment.
Really nice improvement. Can we add an example using this in the testing library too? 🚀
wangyb-A
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a new decorator that enables cleaner API for wait_for_callback operations by allowing submitter functions to accept additional parameters that are bound at call time.
The decorator wraps callables that take callback_id, context, and additional parameters, returning a function that binds those extra parameters and produces a submitter compatible with wait_for_callback.
Changes:
Example usage:
@durable_wait_for_callback def submit_task(callback_id, context, task_name, priority): external_api.submit(task_name, priority, callback_id)
result = context.wait_for_callback(submit_task(my_task, priority=5))
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.