fix(eks-v2-alpha): remove hyphen from Go package name #35927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hyphen from Go package name to follow Go naming conventions. Changes package name from awscdkeks-v2alpha to awscdkeksv2alpha.
aws-cdk-automation
previously requested changes
Nov 3, 2025
mrgrain
added
the
pr/request-cli-integ-tests
mrgrain
changed the title
mrgrain
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
approved these changes
Nov 3, 2025
Contributor
Author
|
Exempted tests since this was failing the main pipeline. The full pipeline passing will show this is workig. |
mrgrain
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
Collaborator
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
The previous Go package name
awscdkeks-v2alphawas not usable in Go because hyphens are not allowed in Go package names. This made the package effectively unusable for Go developers.Description of changes
Updated the Go package name in
package.jsonfromawscdkeks-v2alphatoawscdkeksv2alphaby removing the hyphen. Since the old name was not functional in Go, this rename does not break any existing usage.Describe any new or updated permissions being added
No permission changes.
Description of how you validated changes
This is a metadata-only change to the package configuration that makes the Go package usable.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license