-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: cloudwatch logs transformer support #34863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cloudwatch logs transformer support #34863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #34863 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 2 required status checks are expected.). You can check the last failing draft PR here: #34956. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
@Mergifyio requeue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34861.
Reason for this change
Creates CDK constructs for CloudWatch Logs Transformers. Transformers already have CFN constructs and this achieves functional parity.
Description of changes
Added a
Transformer
construct which is an abstraction overcfnTransformer
.Created a factory class
ProcessorFactory
with static methods to create each of the 5 overarching types of processors described in https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/CloudWatch-Logs-Transformation-Processors.html, namely:ParserProcessor
,VendedLogParser
,StringMutatorProcessor
,JsonMutatorProcessor
andDataConverterProcessor
.These classes implement a
_bind()
method responsible for returning the props expected by CFN constructs for each processor of the respective types.These classes are further split into their processors defined by enums (
ParserProcessorType
,VendedLogType
,StringMutatorType
,JsonMutatorType
,DataConverterType
) and properties for each processor.A
Transformer
expects atransformerConfig
which is a list of processors. Processors can be created using the static methodscreateParserProcessor
,createVendedLogParser
,createStringMutatorProcessor
,createJsonMutatorProcessor
andcreateDataConverterProcessor
in theProcessorFactory
, by passing the type (from the enums defined above) and the relevant props for that processor.ValidationError
is thrown if the expected/required props are not passed.Further validations are performed for limit breaches or positions of parsers being incorrect.
Describe any new or updated permissions being added
Description of how you validated changes
Added unit tests for each processor and each validation. Added integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license