-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs(lambda-event-sources): add schema registry integration docs #34779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Build is failed due to JSII error, could you fix this: |
ozelalisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is in failure mode
| import { CfnRegistry } from 'aws-cdk-lib/aws-glue'; | ||
| import * as iam from 'aws-cdk-lib/aws-iam'; | ||
|
|
||
| export class MskGlueSchemaRegistryStack extends Stack { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an usual pattern for readme examples. Consider if Stack and App are needed here and if they are adding anything to the examples. Typically that's only the case if you want to show interaction between multiple stacks.
Rosetta is failing because the example is inlined into this fixture: https://github.com/aws/aws-cdk/blob/c8d61c9929ef461ccafab2a6e90f11ce635c5750/packages/aws-cdk-lib/rosetta/aws_lambda_event_sources/default.ts-fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, if you decide that a full example is the right way to go about this, you can add a new fixture into this directory that doesn't wrap the code inside a stack.
Then specify the fixture you want to use like this:
```ts fixture=some-fixture
new Stack();
```
See https://github.com/aws/jsii-rosetta?tab=readme-ov-file#fixtures
I'd still recommend that this new fixture contains as much of the setup as possible, e.g. like the imports of Stack and App.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally you may use nofixture, but that's really a last resort.
```ts nofixture
new Stack();
```
Co-authored-by: A. Abdel-Rahman <[email protected]>
Co-authored-by: A. Abdel-Rahman <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #34778.
Reason for this change
The AWS Lambda service recently added support for Schema Registry integration with Kafka event sources. This feature allows customers to use a schema registry (Confluent or Glue) to deserialize events from Kafka topics. While the CDK code support for this feature has been implemented, the documentation was incomplete, making it difficult for users to discover and properly configure this feature.
Description of changes
aws-lambda-event-sourcesREADMEDescribe any new or updated permissions being added
No new permissions are being added in this PR. The documentation describes the existing permissions that are automatically generated when using Glue Schema Registry with Lambda.
Description of how you validated changes
schema-registry.tsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license