Skip to content

Conversation

lassiraa
Copy link
Contributor

This adds the ability to define fileSystemLocations for CodePipeline. Currently, there is not a simple way (or any way that I know of) to do this. This will come in handy when e.g. attaching EFS filesystems to CodePipelines.

Closes #24495.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Mar 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 12, 2023 19:03
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 12, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Mar 13, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 13, 2023 13:37

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@lassiraa
Copy link
Contributor Author

Alright, it seems that the synth input was likely the cause of my earlier issues. The integration tests pass now and I was able to run my own integration test as well. Hopefully everything looks good here now!

@aws-cdk-automation aws-cdk-automation removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Mar 23, 2023
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@mergify mergify bot dismissed otaviomacedo’s stale review April 5, 2023 13:07

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ce3172c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 55906bb into aws:main Apr 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@lassiraa lassiraa deleted the codepipeline-file-system-locations branch April 6, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-codebuild: Add file systems to BuildEnvironment
4 participants