-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(pipelines): allow switching to one CodeBuild action for same-typed assets #13803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally don't mind this change, but I had hoped it would be pluggable.
Probably this needs the AssetPublishing
class to implement some common interface with two default implementations where the user can pick between, and we default to the legacy one.
@rix0rrr I added a flag to select the publishing style |
I'm currently running into an issue where there's too many codebuilds running at the same time to upload assets:
I'm assuming this PR will help solve this problem so 👍 |
@jakejscott did you solve your issue with codebuild? We face the same thing. Since a few days our build pipeline just refuses to work... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thanks for the work on this, much appreciated :-) |
…ed assets (aws#13803) This PR refactors the Asset Stage of the CDK pipeline so that only one FileAsset and one DockerAsset Action are created that are uploading all assets of the respective type. The main benefit of this is improved performance as uploading in parallel does not save enough time to compensate slower startups of multiple CodeBuilds. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Unless I'm missing it, the README or docs don't seem to be very explicit as to which resource the singlePublisherPerType attribute should be set on. Perhaps it could be clarified as to how to implement this. Update: Think I found it, this appears to be called publish_assets_in_parallel now (python) https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.pipelines/CodePipeline.html |
This PR refactors the Asset Stage of the CDK pipeline so that only one FileAsset and one DockerAsset Action are created that are uploading all assets of the respective type.
The main benefit of this is improved performance as uploading in parallel does not save enough time to compensate slower startups of multiple CodeBuilds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license