-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
Labels
bugThis issue is a bug.This issue is a bug.closing-soonThis issue will automatically close in 4 days unless further comments are made.This issue will automatically close in 4 days unless further comments are made.
Description
Describe the bug
When running NodeJS 12.0.0 or higher (tested with 12.0.0 and 12.1.0), the runtime information does not contain the versions for the private NodeJS libraries anymore. The require.resolve function used here doesn't properly return the package module.
I believe this is a breaking change introduced in NodeJS 12.0.0 through this PR: nodejs/node#23683
Maybe for now it's an option to add a NodeJS version constraint to the package.json file with a < 12.0.0.
To Reproduce
- Install NodeJS 12.0.0 or higher (e.g. through nodenv)
- Run the tests for the CDK app
cd /path/to/aws-cdk/packages/@aws-cdk/cdk
../../../node_modules/.bin/nodeunit test/test.app.js- Note how the
runtime library versionsandversion reporting includes only @aws-cdk, aws-cdk and jsii librariestests fail
Expected behavior
Non-failing tests
Version:
- OS: OSX
- Programming Language: NodeJS 12.0.0 +
- CDK Version: 0.31.0
hoegertn
Metadata
Metadata
Assignees
Labels
bugThis issue is a bug.This issue is a bug.closing-soonThis issue will automatically close in 4 days unless further comments are made.This issue will automatically close in 4 days unless further comments are made.