generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 237
Add windows event regex filtering to CWAgent #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dricross
reviewed
Jul 10, 2025
translator/config/sampleSchema/validLogWindowsEventsWithFilters.json
Outdated
Show resolved
Hide resolved
...slator/translate/logs/logs_collected/windows_events/collect_list/ruleEventLogFilters_test.go
Outdated
Show resolved
Hide resolved
...slator/translate/logs/logs_collected/windows_events/collect_list/ruleEventLogFilters_test.go
Outdated
Show resolved
Hide resolved
...slator/translate/logs/logs_collected/windows_events/collect_list/ruleEventLogFilters_test.go
Outdated
Show resolved
Hide resolved
17f2d7f to
a198283
Compare
a5f4df9 to
f7337c8
Compare
5c8f615 to
10f9f0a
Compare
f7337c8 to
1fd0ae9
Compare
lisguo
reviewed
Jul 14, 2025
translator/translate/logs/logs_collected/windows_events/collect_list/ruleEventLogFilters.go
Outdated
Show resolved
Hide resolved
1927170 to
0783b84
Compare
0783b84 to
94fcd20
Compare
27765e3 to
615200a
Compare
615200a to
9fb255f
Compare
dricross
approved these changes
Jul 23, 2025
okankoAMZ
approved these changes
Jul 23, 2025
| cd terraform/eks/addon/gpu | ||
| fi | ||
| terraform destroy -auto-approve | ||
| terraform destroy -auto-approve |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unnecessary change
TravisStark
pushed a commit
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The CloudWatch Agent currently filters Windows Event Logs based on security levels (i.e Error, Critical, Information...). This does not allow customers to collect specific and relevant logs to CloudWatch
Description of changes
sample configuration of regex filtering
Caution
This PR has a testing PR linked to here:aws/amazon-cloudwatch-agent-test#555, merge this first.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Integration test showing Regex filtering passed for all Windows OS Regex Filtering
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.