Create Detaching Unhealthy ASG Instance instead of Terminating #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This article addresses the need to preserve unhealthy AWS Auto Scaling Group (ASG) instances for analysis. It introduces a Lambda-based solution to retain these instances, circumventing ASG's automatic termination. The piece outlines how to use CloudFormation for easy setup, enabling detailed investigation of instance failures without affecting ASG performance. The goal is to enhance troubleshooting efficiency and system reliability through automated, user-friendly configurations.
xzaws
commented
May 8, 2024
|
|
||
| for asg_name in ASG_NAMES: | ||
| unhealthy_instances, desired_capacity = process_asg(asg_name) | ||
| max_detach_by_percent = int(desired_capacity * 0.1) |
Author
There was a problem hiding this comment.
Please change this line to:
max_detach_by_percent = max(int(desired_capacity * 0.1),1) # Ensure minimum 1 if there are unhealthy instances.
Otherwise, when the desired capacity is less than 10. This script won't detach any unhealthy instance. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This article addresses the need to preserve unhealthy AWS Auto Scaling Group (ASG) instances for analysis. It introduces a Lambda-based solution to retain these instances, circumventing ASG's automatic termination. The piece outlines how to use CloudFormation for easy setup, enabling detailed investigation of instance failures without affecting ASG performance. The goal is to enhance troubleshooting efficiency and system reliability through automated, user-friendly configurations.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.