fix(DBParameterGroup): false drift on provided default value #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrfr
reviewed
Jun 30, 2025
| // Parameter 'source' can either be 'engine-default', 'user' or 'system' | ||
| // Here, we should only consider parameters modified by the user | ||
| return currentDBParameters.entrySet().stream() | ||
| .filter(entry -> "user".equals(entry.getValue().source())) |
There was a problem hiding this comment.
I think this is a good simplification of the code, but it does not fix the bug reported in aws-cloudformation/cloudformation-coverage-roadmap#1699.
Specifically, it does not handle the case when the parameter group is created with the template specifying the same value as the default. This is because Source will still be set to system or engine-default. (I'm not sure it's possible to fix this without a change to the RDS API.)
zrfr
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where false drift would be reported when user specifies parameter value that is equal to engine default value.