Skip to content

Conversation

@s-kenji
Copy link
Member

@s-kenji s-kenji commented Jul 26, 2024

Description

  • Refactor pkg_vlun module
  • Split the functions to output files into an exporter module.
  • Add test cases for pkg_vlun module
    • Previously we reused test files for dockerfile scan result. So created new test files to cover code branches in pkg_vlun module as much as possible.
  • Add unit test cases to verify exported csv/markdown files.
    • Compare test csv/markdown files generated before this refactoring (modified format of markdown files slightly) with generated files in the refactored logic.

Testing

  • make test
  • Build the docker image, run the main.py in the container, and verified makrdown/csv files are generated as expected.

@s-kenji s-kenji force-pushed the refactoring_pkg_vuln branch from bbcb0bc to 0c0b077 Compare July 26, 2024 13:32
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:32 — with GitHub Actions Inactive
@s-kenji s-kenji force-pushed the refactoring_pkg_vuln branch from 0c0b077 to cfe6d4b Compare July 26, 2024 13:38
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 13:38 — with GitHub Actions Inactive
@s-kenji s-kenji force-pushed the refactoring_pkg_vuln branch from cfe6d4b to 734f6c1 Compare July 26, 2024 14:15
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 14:15 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 14:15 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 14:15 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 14:15 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 14:15 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 19:06 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 19:06 — with GitHub Actions Inactive
@s-kenji s-kenji force-pushed the refactoring_pkg_vuln branch from 8d0eebd to f9de12a Compare July 26, 2024 20:34
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:34 — with GitHub Actions Inactive
@s-kenji s-kenji force-pushed the refactoring_pkg_vuln branch from f9de12a to 105d579 Compare July 26, 2024 20:37
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
@s-kenji s-kenji temporarily deployed to plugin-development July 26, 2024 20:37 — with GitHub Actions Inactive
Copy link
Contributor

@bluesentinelsec bluesentinelsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much improved, thanks!

@bluesentinelsec bluesentinelsec merged commit b9f4abf into main Jul 29, 2024
@bluesentinelsec bluesentinelsec deleted the refactoring_pkg_vuln branch July 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants