Skip to content

cleanup #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

cleanup #117

wants to merge 2 commits into from

Conversation

@SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Oct 26, 2024

  • move common settings to Directory.Build.props
  • move to c# 12
  • add a global json with a min sdk of 8.0.403 and roll forward
  • remove redundant usings

@awaescher awaescher changed the base branch from main to refactorings October 26, 2024 20:37
@awaescher
Copy link
Owner

awaescher commented Oct 26, 2024 •
edited
Loading

Hi Simon, I just merged your pull-requests into a new branch to collect the changes (#122) to prevent the CD pipeline from going wild.
Thanks so much for helping out, really appreciate it.
This pull-request has some conflicts after I merged quite a big one #111.

@awaescher awaescher deleted the branch awaescher:refactorings October 30, 2024 07:21
@awaescher awaescher closed this Oct 30, 2024
@awaescher awaescher reopened this Oct 30, 2024
@awaescher
Copy link
Owner

awaescher commented Oct 30, 2024

This was closed accidentially after the refacorings branch was deleted.
Would you rebase your changes?

@awaescher
Copy link
Owner

awaescher commented Jan 3, 2025

Closed as stale

@awaescher awaescher closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonCropp @awaescher