Skip to content

Conversation

@manuelmeurer
Copy link
Contributor

Description

Pagy v43 is out: https://ddnexus.github.io/pagy/changelog/#version-4300
It has lots of changes that are incompatible with the current implementation in Avo.
This is why I think it makes sense to limit the dependency to < v43 in the gemspec.
Not sure if the entry in Gemfile can then be removed?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Add Avo to a app that uses pagy v43
  2. App won't start due to errors
  3. Limit pagy dependency to < v43
  4. App starts fine.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for the contribution @manuelmeurer!

@Paul-Bob Paul-Bob added the Fix label Nov 5, 2025
@Paul-Bob Paul-Bob merged commit b111eb1 into avo-hq:main Nov 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants