fix: attach scope #4029
Merged
fix: attach scope #4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4028
apply_attach_scopeon theAvo::SearchControllerwas assuming a nested association chain likeUser -> Create new Workspace -> Search for an Organization to attach to the workspace
In the above scenario, when creating a new workspace to hydrate the attach scope with a parent, the code was assuming that the workspace and user association was always a belongs to or has one. When the association is a collection, it breaks. This PR changes it by checking the parent and grandparent association type before assigning the grandparent to the parent record.
Thanks for the detailed issue and reproduction repository @icaroryan, that made my intervention in finding and fixing the bug really productive!