Skip to content

Fix: Country field copies wrong clipboard value when copyable: true #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2025
Merged

Fix: Country field copies wrong clipboard value when copyable: true #4005

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f516a2
Fix country field bug
zhephyn Aug 2, 2025
78b4c11
Remove view duplication
zhephyn Aug 4, 2025
b5ab9c1
Fix CI fail
zhephyn Aug 4, 2025
affe7bc
Fix Rubocop CI fail
zhephyn Aug 4, 2025
668b467
Refactor value method in country_field.rb file
zhephyn Aug 4, 2025
ef83140
Merge branch 'main' into fix-country-field-bug
zhephyn Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/components/avo/field_wrapper_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@
<%= content %>
<% end %>
<% if @field.copyable %>
<%= render Avo::ClipboardComponent.new(value: @field.value) %>
<%
copy_value = if @field.is_a?(Avo::Fields::CountryField) && [email protected]_code
@field.countries[@field.value]
else
@field.value
end
%>
<%= render Avo::ClipboardComponent.new(value: copy_value) %>
<% end %>
</div>
<% elsif on_edit? %>
Expand Down
9 changes: 8 additions & 1 deletion app/components/avo/index/field_wrapper_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,14 @@
<%= content %>
<% end %>
<% if @field.copyable %>
<%= render Avo::ClipboardComponent.new(value: @field.value) %>
<%
copy_value = if @field.is_a?(Avo::Fields::CountryField) && [email protected]_code
@field.countries[@field.value]
else
@field.value
end
%>
<%= render Avo::ClipboardComponent.new(value: copy_value) %>
<% end %>
<% end %>
<% if params[:avo_debug].present? %>
Expand Down
Loading